Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5981) [helm] agent preset replicas #5984

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 8, 2024

What does this PR do?

This PR sets correctly the replicas of agent presets (including the value of 0) and fixes some markdown issues in the chart examples

Why is it important?

Because users should be able scale presets according to their needs

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

How to test this PR locally

Follow kubernetes example and in the install command add this --set agent.presets.clusterWide.replicaCount=2 or --set agent.presets.clusterWide.replicaCount=0

Related issues

N/A


This is an automatic backport of pull request #5981 done by Mergify.

* fix: set correct replicas of deployment and statefulset presets

* fix: examples markdown fixes

(cherry picked from commit f994f5b)
@mergify mergify bot requested a review from a team as a code owner November 8, 2024 13:41
@mergify mergify bot added the backport label Nov 8, 2024
@mergify mergify bot requested review from pkoutsovasilis and andrzej-stencel and removed request for a team November 8, 2024 13:41
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert enabled auto-merge (squash) November 8, 2024 16:01
@pierrehilbert pierrehilbert merged commit d55a54a into 8.x Nov 8, 2024
10 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.x/pr-5981 branch November 8, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants